Skip to content

Update server-service.yaml#877

Closed
iamhritik wants to merge 1 commit intotemporalio:mainfrom
iamhritik:main
Closed

Update server-service.yaml#877
iamhritik wants to merge 1 commit intotemporalio:mainfrom
iamhritik:main

Conversation

@iamhritik
Copy link
Copy Markdown

What was changed

Added a conditional check to only create the 'internalFrontend' service when 'internalFrontend.enabled: true' in values. The service list is now dynamically constructed instead of always iterating over both 'frontend' and 'internalFrontend'.

Why?

Previously, the template always created Service resources for both 'frontend' and 'internalFrontend' regardless of their enabled status. This resulted in unnecessary/invalid service resources when 'internalFrontend.enabled: false'. The fix ensures services are only created when explicitly enabled.

How was this changed

# Before: Always iterates over both services
{{- range $rawService := (list "frontend" "internalFrontend") }}
# After: Dynamically builds list based on enabled flags
{{- $services := list "frontend" }}
{{- if $.Values.server.internalFrontend.enabled }}
{{-   $services = concat $services (list "internalFrontend") }}
{{- end }}
{{- range $rawService := $services }}

Checklist

  1. Closes
  2. How was this tested:
    Ran helm template . between main and this branch, and verified that only diff is this config.
  3. Any docs updates needed?

adding condition to  create internalFrontend service based on enabled flag
@iamhritik iamhritik requested a review from a team as a code owner April 5, 2026 04:16
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 5, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@robholland
Copy link
Copy Markdown
Contributor

We already check .enabled for the services and there are tests covering this case: https://github.com/temporalio/helm-charts/pull/877/changes#diff-486a112e02d2716ae96ff167bf2ab4117023c57043a9a1a6a76325e0a00560b9L4.

The reason you are seeing this behaviour is a stale values file that has "internalFrontend" key instead of "internal-frontend". I will add a validation to help people spot this and add a note to UPGRADING.md.

@robholland robholland closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants